[stunnel-users] stunnel beta (5.04b1) is available for testing

Michal Trojnara Michal.Trojnara at mirt.net
Tue Sep 16 19:25:22 CEST 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Pierre,

> Be careful not to take unicode patch "partly"

Unfortunately applying a single huge patch makes the code hard to
maintain and occasionally breaks some features that are not used by
the author of the patch.

> because many pieces of codes are relying one on the other,
> sometimes indirectly (eg through sprintf).

Honestly, I don't like the idea of using format strings that are
clearly documented by Microsoft as obsolete and likely to be
incompatible with future versions of Windows.

When compiled with MinGW it results with the following warnings:
ui_win_gui.c: In function ‘edit_config’:
ui_win_gui.c:1117:17: warning: format ‘%hs’ expects argument of type
‘short int *’, but argument 2 has type ‘TCHAR *’ [-Wformat]
ui_win_gui.c: In function ‘service_install’:
ui_win_gui.c:1182:9: warning: format ‘%hs’ expects argument of type
‘short int *’, but argument 2 has type ‘TCHAR *’ [-Wformat]
ui_win_gui.c:1182:9: warning: format ‘%hs’ expects argument of type
‘short int *’, but argument 3 has type ‘LPSTR’ [-Wformat]

> It was not obvious to track all of the modifications in 502.

Quoting Linus:
https://www.kernel.org/doc/Documentation/SubmittingPatches

<begin of quote>

3) Separate your changes.

Separate _logical changes_ into a single patch file.

For example, if your changes include both bug fixes and performance
enhancements for a single driver, separate those changes into two
or more patches.  If your changes include an API update, and a new
driver which uses that new API, separate those into two patches.

On the other hand, if you make a single change to numerous files,
group those changes into a single patch.  Thus a single logical change
is contained within a single patch.

If one patch depends on another patch in order for a change to be
complete, that is OK.  Simply note "this patch depends on patch X"
in your patch description.

If you cannot condense your patch set into a smaller set of patches,
then only post say 15 or so at a time and wait for review and integration.

<end of quote>

Mike
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlQYcoIACgkQ/NU+nXTHMtF/FgCg4vB2Oxo6v2GakR+qcuPPP83K
h20AoNqJ6jqWVaVAL1belyXquUySXMku
=5kyk
-----END PGP SIGNATURE-----


More information about the stunnel-users mailing list